Skip to content

Migrate pygmt.config tests to dvc #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2021
Merged

Migrate pygmt.config tests to dvc #1165

merged 2 commits into from
Apr 4, 2021

Conversation

@seisman
Copy link
Member

@seisman seisman commented Apr 3, 2021

Description of proposed changes

Related to #1131.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman mentioned this pull request Apr 3, 2021
Closed
28 tasks
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 3, 2021
@seisman seisman added this to the 0.4.0 milestone Apr 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2021 •
edited
Loading

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_config.png
added pygmt/tests/baseline/test_config_font_annot.png
added pygmt/tests/baseline/test_config_font_one.png
added pygmt/tests/baseline/test_config_format_time_map.png
added pygmt/tests/baseline/test_config_map_annot_offset.png
added pygmt/tests/baseline/test_config_map_grid_cross_size.png
added pygmt/tests/baseline/test_config_map_grid_pen.png
added pygmt/tests/baseline/test_config_map_tick_length.png
added pygmt/tests/baseline/test_config_map_tick_pen.png

Image diff(s)

  • pygmt/tests/baseline/test_config.png

  • pygmt/tests/baseline/test_config_font_annot.png

  • pygmt/tests/baseline/test_config_font_one.png

  • pygmt/tests/baseline/test_config_format_time_map.png

  • pygmt/tests/baseline/test_config_map_annot_offset.png

  • pygmt/tests/baseline/test_config_map_grid_cross_size.png

  • pygmt/tests/baseline/test_config_map_grid_pen.png

  • pygmt/tests/baseline/test_config_map_tick_length.png

  • pygmt/tests/baseline/test_config_map_tick_pen.png

Report last updated at commit fe300d9

weiji14
weiji14 reviewed Apr 4, 2021
View reviewed changes
weiji14
weiji14 approved these changes Apr 4, 2021
View reviewed changes
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @seisman!

@seisman seisman merged commit 155ad1d into master Apr 4, 2021
@seisman seisman deleted the dvc-config branch April 4, 2021 03:43
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
@seisman
Migrate pygmt.config tests to dvc (GenericMappingTools#1165)
2162cff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14 weiji14 weiji14 approved these changes

Assignees

No one assigned

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@seisman @weiji14